Skip to content

HDFS-13603: Do not propagate ExecutionException while initializing edek queues for keys.#6860

Merged
simbadzina merged 1 commit intoapache:trunkfrom
yzhang559:HDFS-13603-common
Jun 3, 2024
Merged

HDFS-13603: Do not propagate ExecutionException while initializing edek queues for keys.#6860
simbadzina merged 1 commit intoapache:trunkfrom
yzhang559:HDFS-13603-common

Conversation

@yzhang559
Copy link
Contributor

@yzhang559 yzhang559 commented May 31, 2024 •
edited
Loading

JIRA = https://issues.apache.org/jira/browse/HDFS-13603

Description of PR

throw IOException at last if cache warmup fail for any keys, continue to warmup other keys.

This is the changes in hadoop-common from PR #6774

How was this patch tested?

new unit test is added

mvn test -Dtest=TestValueQueue
[INFO] Running org.apache.hadoop.crypto.key.TestValueQueue
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.077 s - in org.apache.hadoop.crypto.key.TestValueQueue

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@yzhang559 yzhang559 mentioned this pull request May 31, 2024
Merged
4 tasks
@simbadzina simbadzina changed the title HDFS-13603: do not propagate ExecutionException during initalize edek… HDFS-13603: Do not propagate ExecutionException during initalize edek queues for keys. May 31, 2024
@hadoop-yetus
Copy link

hadoop-yetus commented Jun 1, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 47s Maven dependency ordering for branch
+1 💚 mvninstall 36m 36s trunk passed
+1 💚 compile 19m 34s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 compile 18m 54s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 checkstyle 1m 28s trunk passed
+1 💚 mvnsite 2m 26s trunk passed
+1 💚 javadoc 1m 57s trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 1m 33s trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 spotbugs 3m 44s trunk passed
+1 💚 shadedclient 39m 30s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 1m 41s Maven dependency ordering for patch
+1 💚 mvninstall 1m 17s the patch passed
+1 💚 compile 18m 41s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javac 18m 41s the patch passed
+1 💚 compile 17m 55s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 javac 17m 55s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 27s the patch passed
+1 💚 mvnsite 2m 25s the patch passed
+1 💚 javadoc 1m 50s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1
+1 💚 javadoc 1m 28s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
+1 💚 spotbugs 3m 49s the patch passed
+1 💚 shadedclient 39m 25s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 20m 32s hadoop-common in the patch passed.
+1 💚 unit 3m 51s hadoop-kms in the patch passed.
+1 💚 asflicense 1m 4s The patch does not generate ASF License warnings.
265m 43s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6860/1/artifact/out/Dockerfile
GITHUB PR #6860
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 300504947fed 5.15.0-107-generic #117-Ubuntu SMP Fri Apr 26 12:26:49 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f4d5222
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6860/1/testReport/
Max. process+thread count 3134 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms U: hadoop-common-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6860/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

simbadzina
simbadzina approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@simbadzina simbadzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feedback was mostly discussed on #6774 before we decided to split the hadoop-common changes into a separate PR.

@simbadzina simbadzina changed the title HDFS-13603: Do not propagate ExecutionException during initalize edek queues for keys. HDFS-13603: Do not propagate ExecutionException while initializing edek queues for keys. Jun 3, 2024
@simbadzina simbadzina merged commit f1e2ceb into apache:trunk Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simbadzina simbadzina simbadzina approved these changes

Assignees

No one assigned

Labels

Common trunk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yzhang559 @hadoop-yetus @simbadzina